Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using SPI default pins #12367

Merged
merged 2 commits into from Feb 15, 2023
Merged

Using SPI default pins #12367

merged 2 commits into from Feb 15, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Feb 14, 2023

Move defaults for SPI pins to the platform for the MCU family.

Note that there is further SPI PRs to come, as it is spread across multiple files. This is merely to get the config builds working.

@blckmn blckmn self-assigned this Feb 14, 2023
@blckmn blckmn mentioned this pull request Feb 14, 2023
Merged
@haslinghuis haslinghuis added this to the 4.5 milestone Feb 14, 2023
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn
Copy link
Member Author

blckmn commented Feb 14, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@blckmn blckmn merged commit 9e36ba6 into betaflight:master Feb 15, 2023
@blckmn blckmn deleted the spi_none branch February 16, 2023 20:28
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@blckmn @davidbitton
Using SPI default pins (betaflight#12367)
5c309d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@klutvott123 klutvott123 klutvott123 approved these changes

@sugaarK sugaarK sugaarK approved these changes

@KarateBrot KarateBrot Awaiting requested review from KarateBrot

@SteveCEvans SteveCEvans Awaiting requested review from SteveCEvans

Assignees

@blckmn blckmn

Labels
Cleanup Ready to Merge RN: REFACTORING
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blckmn @haslinghuis @klutvott123 @sugaarK