Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AT32 initial dshot support #12464

Merged
merged 5 commits into from Mar 9, 2023
Merged

Conversation

JBKingdon
Copy link
Contributor

@JBKingdon JBKingdon commented Mar 6, 2023

AT32 Initial implementation of dshot

Supports timer-pwm output and telemetry.
Burst mode and bitbang are not implemented.

When testing with configurator some error rate is seen when connected by the normal USB VCP port for dshot600 @ 8kHz, but this goes away when connected via a serial adapter to a normal uart.

Just enough dshot implementation to do timer pwm dshot output only.
Still to do:
  telemetry, burst mode, bitbang
Enables bidir dshot for telemetry on AT32. Only timer-pwm is
supported, without burst mode.
Removed a conflicting definition from target.h and added the PA9/10 uart pins
for the at-link serial connection, but these don't seem to be active until
added from the cli.
@github-actions

This comment has been minimized.

@JBKingdon
Copy link
Contributor Author

dshot600, only 1 esc connected
image

@haslinghuis haslinghuis added this to the 4.5 milestone Mar 6, 2023
@blckmn
Copy link
Member

blckmn commented Mar 6, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

Hopefully fix problems with unit tests by making erpmToRpm conditionally
compiled again.
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn blckmn merged commit c5f3f86 into betaflight:master Mar 9, 2023
18 checks passed
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
* AT32 dshot part1

Just enough dshot implementation to do timer pwm dshot output only.
Still to do:
  telemetry, burst mode, bitbang

* AT32 Implement dshot telemetry

Enables bidir dshot for telemetry on AT32. Only timer-pwm is
supported, without burst mode.

* Updates for target.h and config.h

Removed a conflicting definition from target.h and added the PA9/10 uart pins
for the at-link serial connection, but these don't seem to be active until
added from the cli.

* Wrap erpmToRpm in #def

Hopefully fix problems with unit tests by making erpmToRpm conditionally
compiled again.

---------

Co-authored-by: J Blackman <blckmn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

3 participants