Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX CONFIG: MATEKF405TEMINI SPI3 + CONFIG DEFAULT_VOLTAGE_METER_SCALE + SYSTEM_HSE_MHZ #12468

Merged
merged 3 commits into from Mar 7, 2023
Merged

FIX CONFIG: MATEKF405TEMINI SPI3 + CONFIG DEFAULT_VOLTAGE_METER_SCALE + SYSTEM_HSE_MHZ #12468

merged 3 commits into from Mar 7, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Mar 6, 2023 •
edited

Fixes: #12466

Adds: DEFAULT_VOLTAGE_METER_SCALE
Fixes: SYSTEM_HSE_MHZ

image

@haslinghuis haslinghuis added this to the 4.5 milestone Mar 6, 2023
@haslinghuis haslinghuis self-assigned this Mar 6, 2023
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis requested a review from blckmn March 6, 2023 19:42
@haslinghuis haslinghuis changed the title Fix MATEKF405TEMINI Fix MATEKF405TEMINI and add DEFAULT_VOLTAGE_METER_SCALE Mar 6, 2023
@github-actions

This comment has been minimized.

Sign in to view
@TheIsotopes
Copy link
Contributor

@haslinghuis I tested this pr ... so far everything is fine ... except that system_hse_mhz = 0 is still not set correctly.

@haslinghuis haslinghuis changed the title Fix MATEKF405TEMINI and add DEFAULT_VOLTAGE_METER_SCALE FIX CONFIG: MATEKF405TEMINI SPI3 + CONFIG DEFAULT_VOLTAGE_METER_SCALE + SYSTEM_HSE_MHZ Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@haslinghuis
Copy link
Member Author

@TheIsotopes fixed the crystal frequency 🤞

@TheIsotopes
Copy link
Contributor

@haslinghuis ok, everything works as it should. 👍

@betaflight betaflight deleted a comment from blckmn Mar 7, 2023
@haslinghuis haslinghuis merged commit f41b3e9 into betaflight:master Mar 7, 2023
@haslinghuis haslinghuis deleted the fix-matek branch March 7, 2023 03:49
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@haslinghuis @davidbitton
FIX CONFIG: MATEKF405TEMINI SPI3 + CONFIG DEFAULT_VOLTAGE_METER_SCALE…
8fc578e 
… + SYSTEM_HSE_MHZ (betaflight#12468)

* Fix MATEKF405TEMINI

* Add VBAT_SCALE

* Fix SYSTEM_HSE_MHZ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

@klutvott123 klutvott123 klutvott123 approved these changes

@sugaarK sugaarK Awaiting requested review from sugaarK

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX RN: TARGET UPDATE Tested
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

No gyro found
5 participants
@haslinghuis @TheIsotopes @blckmn @KarateBrot @klutvott123