New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX CONFIG: MATEKF405TE /MINI #12492
Conversation
This comment has been minimized.
This comment has been minimized.
AUTOMERGE: (FAIL)
|
#define GYRO_1_ALIGN_YAW 2700 | ||
|
||
#define DEFAULT_RX_FEATURE FEATURE_RX_SERIAL | ||
#define SERIALRX_PROVIDER SERIALRX_CRSF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheIsotopes please configure the serial port before we assign the function:
#define SERIALRX_PROVIDER SERIALRX_CRSF | |
#define SERIALRX_PROVIDER SERIALRX_CRSF | |
#define SERIALRX_UART SERIAL_PORT_USART2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also in doubt if we should define the SERIALRX_PROVIDER for non SPI boards as we can do that using the build API options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Do you want to test this code? Here you have an automated build: |
@haslinghuis I just looked at the config's ... I changed my mind to conform to the majority. imo we should delete these definitions from all controllers. there are only four left from MATEKSYS. EDIT: fragments of these definitions can be found on some controllers, but these are commented out.
then only controllers with these definitions can be found.
|
corresponds to |
this is only meant as a placeholder, usually 2 and 6 with MATEKSYS. |
Try flashing latest F405TEMINI without this define Fixed in #12496 But still think we need to bring over serial settings from unified targets. |
@haslinghuis It was just an idea to change that. |
ok, it's ready to merge now 👍 |
* FIX CONFIG: MATEKF405TE /MINI * changes as requested
These two controllers are absolutely identical except for the storage medium.
I have adjusted and fixed the config on both and they can be better compared now.
SD card on MATEKF405TE should now work correctly.