Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX CONFIG: MATEKF405TE /MINI #12492

Merged
merged 2 commits into from Mar 10, 2023
Merged

FIX CONFIG: MATEKF405TE /MINI #12492

merged 2 commits into from Mar 10, 2023

Conversation

TheIsotopes
Copy link
Contributor

@TheIsotopes TheIsotopes commented Mar 9, 2023

These two controllers are absolutely identical except for the storage medium.
I have adjusted and fixed the config on both and they can be better compared now.

SD card on MATEKF405TE should now work correctly.

@github-actions

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Mar 10, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

#define GYRO_1_ALIGN_YAW 2700

#define DEFAULT_RX_FEATURE FEATURE_RX_SERIAL
#define SERIALRX_PROVIDER SERIALRX_CRSF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheIsotopes please configure the serial port before we assign the function:

Suggested change
#define SERIALRX_PROVIDER SERIALRX_CRSF
#define SERIALRX_PROVIDER SERIALRX_CRSF
#define SERIALRX_UART SERIAL_PORT_USART2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in doubt if we should define the SERIALRX_PROVIDER for non SPI boards as we can do that using the build API options.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@TheIsotopes
Copy link
Contributor Author

TheIsotopes commented Mar 10, 2023

@haslinghuis I just looked at the config's ... I changed my mind to conform to the majority.

imo we should delete these definitions from all controllers. there are only four left from MATEKSYS.

EDIT: fragments of these definitions can be found on some controllers, but these are commented out.

#define DEFAULT_RX_FEATURE     FEATURE_RX_SERIAL
#define SERIALRX_PROVIDER      SERIALRX_xyz
#define SERIALRX_UART          SERIAL_PORT_USARTx

then only controllers with these definitions can be found.

#define RX_SPI_DEFAULT_PROTOCOL         RX_SPI_EXPRESSLRS
#define DEFAULT_RX_FEATURE              FEATURE_RX_SPI
#define RX_SPI_PROTOCOL                 EXPRESSLRS

@haslinghuis
Copy link
Member

#define SERIALRX_UART SERIAL_PORT_USARTx

corresponds to serial x 64 ... setting in CLI

@TheIsotopes
Copy link
Contributor Author

this is only meant as a placeholder, usually 2 and 6 with MATEKSYS.

@haslinghuis
Copy link
Member

haslinghuis commented Mar 10, 2023

Try flashing latest F405TEMINI without this define

Fixed in #12496

But still think we need to bring over serial settings from unified targets.

@TheIsotopes
Copy link
Contributor Author

@haslinghuis It was just an idea to change that.
If it is still on your plan to adopt these definitions from the unified targets, we should leave this PR as it is now.

@TheIsotopes
Copy link
Contributor Author

ok, it's ready to merge now 👍

@haslinghuis haslinghuis merged commit 6d4921e into betaflight:master Mar 10, 2023
@TheIsotopes TheIsotopes deleted the matekf405te_fix branch March 10, 2023 19:33
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
* FIX CONFIG: MATEKF405TE /MINI

* changes as requested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

4 participants