Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set DSHOT default #12508

Merged
merged 1 commit into from Mar 16, 2023
Merged

Set DSHOT default #12508

merged 1 commit into from Mar 16, 2023

Conversation

haslinghuis
Copy link
Member

Set DSHOT300 for F411 otherwise DSHOT600 if USE_DSHOT is defined.

@haslinghuis haslinghuis added this to the 4.5 milestone Mar 11, 2023
@haslinghuis haslinghuis self-assigned this Mar 11, 2023
@github-actions

This comment has been minimized.

Sign in to view
@TheIsotopes
Copy link
Contributor

imo the F405 should also set to DSHOT300.

@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Mar 11, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

blckmn
blckmn requested changes Mar 13, 2023
View reviewed changes
src/main/pg/motor.c Outdated Show resolved Hide resolved
@blckmn
Copy link
Member

blckmn commented Mar 13, 2023

No more #ifdef STM32XXX allowed in mainstream code. Need to get out of the habit folks!!!

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn blckmn merged commit 1406e29 into betaflight:master Mar 16, 2023
@haslinghuis haslinghuis deleted the set-default-dshot branch March 16, 2023 09:09
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@haslinghuis @davidbitton
Set DSHOT default (betaflight#12508)
ce98048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheIsotopes TheIsotopes TheIsotopes approved these changes

@blckmn blckmn blckmn approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: IMPROVEMENT
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haslinghuis @TheIsotopes @blckmn @nerdCopter