Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position: Remove 15 m/s limit on estimated vario #12669

Merged
merged 1 commit into from Apr 13, 2023

Conversation

mluessi
Copy link
Contributor

@mluessi mluessi commented Apr 12, 2023

The estimated vario is currently limited to +/- 15 m/s. I have a report from a pilot who likes to dive mountains who has the vario shown in the OSD not going over 15 m/s.

It is not clear to me why the 15 m/s limit is needed and this removes the limit. Alternatively, the limit could also be increased to allow for higher vertical velocities.

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@haslinghuis haslinghuis added this to the 4.5 milestone Apr 13, 2023
@blckmn
Copy link
Member

blckmn commented Apr 13, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> PASS

@ctzsnooze
Copy link
Member

I also don't know why that limit was there - happy to see it go.

@haslinghuis haslinghuis merged commit 7040530 into betaflight:master Apr 13, 2023
18 checks passed
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
Position: remove 15 m/s limit on estimated vario
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

5 participants