Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing cfg_pms.version #12695

Merged
merged 1 commit into from Apr 19, 2023
Merged

Fix missing cfg_pms.version #12695

merged 1 commit into from Apr 19, 2023

Conversation

SteveCEvans
Copy link
Member

version field was not being populated, so the PMS command failed randomly due to uninitialised data.

@SteveCEvans SteveCEvans self-assigned this Apr 18, 2023
@SteveCEvans SteveCEvans mentioned this pull request Apr 18, 2023
Merged
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@haslinghuis haslinghuis added this to the 4.5 milestone Apr 18, 2023
@blckmn
Copy link
Member

blckmn commented Apr 19, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@KarateBrot KarateBrot merged commit fea097a into betaflight:master Apr 19, 2023
18 checks passed
AkankshaJjw pushed a commit to AkankshaJjw/betaflight that referenced this pull request May 29, 2023
@SteveCEvans @AkankshaJjw
Fix missing cfg_pms.version (betaflight#12695)
3e2b00e
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@SteveCEvans @davidbitton
Fix missing cfg_pms.version (betaflight#12695)
c5a5fba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

@limonspb limonspb Awaiting requested review from limonspb

@ctzsnooze ctzsnooze Awaiting requested review from ctzsnooze

@klutvott123 klutvott123 Awaiting requested review from klutvott123

Assignees

@SteveCEvans SteveCEvans

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SteveCEvans @blckmn @haslinghuis @KarateBrot