Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Timer Usage Flags #12862

Merged
merged 1 commit into from Jun 6, 2023
Merged

Removing Timer Usage Flags #12862

merged 1 commit into from Jun 6, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Jun 3, 2023

Replacing previous PR #12548 that conflated two separate items.

This one is merely the housekeeping and removal.

@blckmn blckmn added this to the 4.5 milestone Jun 3, 2023
@blckmn blckmn self-assigned this Jun 3, 2023
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #12862 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

@blckmn
Copy link
Member Author

blckmn commented Jun 3, 2023 •
edited

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@blckmn blckmn requested a review from KarateBrot June 6, 2023 01:34
@blckmn blckmn merged commit 7d7b659 into betaflight:master Jun 6, 2023
19 checks passed
@blckmn
Copy link
Member Author

blckmn commented Jun 6, 2023

Merged as I need this in to rebase the AT32 timer PR.

@blckmn blckmn deleted the remove_timer_use_any branch June 7, 2023 03:34
@hydra hydra mentioned this pull request Jun 13, 2023
Merged
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
@blckmn @davidbitton
Removing Timer Usage Flags (betaflight#12862)
f5e7544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@sugaarK sugaarK sugaarK approved these changes

@KarateBrot KarateBrot Awaiting requested review from KarateBrot

Assignees

@blckmn blckmn

Labels
Housekeeping RN: REFACTORING
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blckmn @haslinghuis @sugaarK