Composite CDC+HID for F4 Hotfix #5512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For now disables Composite (it can be enabled, with USB_CDC_HID define) - Modified descriptors so they are properly recognized - Changed PID for Composite device (otherwise it doesn't work probably due to windows feature - automatically finding drivers based on those values)
|
Fixes #5496 |
|
@conkerkh Tested on current an several old OS X versions and this change fixes the problems. Thanks for the quick work. |
mikeller
reviewed
Mar 23, 2018
| @@ -51,7 +51,6 @@ | |||
| #define USE_GYRO_DATA_ANALYSE | |||
| #define USE_ADC | |||
| #define USE_ADC_INTERNAL | |||
| #define USB_CDC_HID | |||
There was a problem hiding this comment.
Thanks for the quick fix, @conkerkh. This looks like it also disables HID for all targets that do not explicitly enable it, which is not what we want for a permanent solution (and before the permanent solution we don't want it so that users can test / provide feedback). What is your take on making this configurable at runtime?
There was a problem hiding this comment.
I like this idea. I can do PG for this.
mikeller
approved these changes
Mar 23, 2018
|
Good job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.