KISSCC: Fix soft serial on TLM pad #7149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
reviewed
Dec 1, 2018
| @@ -84,7 +84,7 @@ | |||
| #define UART3_RX_PIN PB11 // PB11 (AF7) | |||
|
|
|||
| #ifdef KISSCC | |||
| #define SOFTSERIAL1_TX_PIN PA13 | |||
There was a problem hiding this comment.
All of this can be simplified:
#define SOFTSERIAL1_TX_PIN PA13 // KISSFC: AUX1, KISSCC: TLM
#if !defined(KISSCC)
#define SOFTSERIAL2_TX_PIN PA15 // ROLL
#endif
mikeller
requested changes
Dec 8, 2018
src/main/target/KISSFC/target.h
Outdated
| @@ -84,7 +84,7 @@ | |||
| #define UART3_RX_PIN PB11 // PB11 (AF7) | |||
|
|
|||
| #ifdef KISSCC | |||
| #define SOFTSERIAL1_TX_PIN PA13 | |||
| #define SOFTSERIAL1_TX_PIN PA13 // TLM | |||
There was a problem hiding this comment.
@robertlacroix: Can you simplify this please?
There was a problem hiding this comment.
Yeah, sorry busy the last couple of days. I’ll send an updated change soon
There was a problem hiding this comment.
@mikeller done
_Legal disclaimer: I am making my contributions/submissions to this project solely in my personal capacity and am not conveying any rights to any intellectual property of any third parties._
robertlacroix
force-pushed
the
kisscc-tlm-serial
branch
from
555cf1f
to
44504f1
Compare
mikeller
approved these changes
Dec 26, 2018
mikeller
added a commit
that referenced
this pull request
Dec 27, 2018
KISSCC: Fix soft serial on TLM pad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7147
Legal disclaimer: I am making my contributions/submissions to this project solely in my personal capacity and am not conveying any rights to any intellectual property of any third parties.