New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new target RUSHCORE7 #7338
Add new target RUSHCORE7 #7338
Conversation
Have ome mistakes,it's use gcc-arm-none-eabi-7-2018-q2-update and mainteance compile before. |
This is the same PR as closed #7333?what differences? |
okey, the previous one was open against master |
I think that GYRO1_CS_PIN now works on 3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request system is not intended to be used to find / fix compilation / functional errors. Before opening a pull request for a new target, please make sure that:
- your target builds;
- basic function checks succeed, i.e. the target boots, and the acc / gyro works,...
@mikeller my comment was regarding MPU6500_CS_PIN vs. GYRO_1_CS_PIN definitions and related ones. They are both supported in 3.5.x in parallel. For sure generic target need a different PR for the config. |
Rush authorization add new target RUSHCORE7. https://www.rushfpv.com Update target.c Update target.h Change GYRO/ACC define for 3.5.x Update Board - RUSHCORE7.md Delete the pic reference Update target.mk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest looks good.
delete RUSHCORE7 - pic1.jpg and RUSHCORE7 - pic2.jpg
@MJ666: Have your concerns with this been addressed? |
Looks all good to me. |
Added board description link to wiki. |
@nyway: Now that the format for Unified Target configurations for Betaflight 4.0 has been defined, and a process to create them established, can you please open a pull request to get this target added to the We can do this for you, but since we do not have the actual hardware, this will mean that the target will be untested and potentially broken in 4.0, so it is preferrable if you do this, and test the resulting firmware and Unified Target configuration before submitting the pull request. |
@mikeller |
@nyway: Those two are already in 4.0 as 'legacy' targets (in |
Add new target RUSHCORE7 Added target RUSHCORE7 to 4.0.
Rush authorization add new target RUSHCORE7.
https://www.rushfpv.com