Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new target RUSHCORE7 #7338

Merged
merged 2 commits into from Jan 12, 2019
Merged

Add new target RUSHCORE7 #7338

merged 2 commits into from Jan 12, 2019

Conversation

nyway
Copy link
Contributor

@nyway nyway commented Jan 5, 2019

Rush authorization add new target RUSHCORE7.
https://www.rushfpv.com

pic-rush

@nyway
Copy link
Contributor Author

nyway commented Jan 5, 2019

Have ome mistakes,it's use gcc-arm-none-eabi-7-2018-q2-update and mainteance compile before.
Will change to gcc-arm-none-eabi-7-2017-q4-major 3.5.x-mainteance and do some test later.

@asizon
Copy link
Member

asizon commented Jan 5, 2019

This is the same PR as closed #7333?what differences?
Please read:
https://github.com/betaflight/betaflight#embargo-on-new-targets-for-betaflight-40

@nyway
Copy link
Contributor Author

nyway commented Jan 5, 2019

@asizon
This is against Betaflight 3.5.x-maintenance.
#7333Against Betaflight 4.x.x

@asizon
Copy link
Member

asizon commented Jan 5, 2019

okey, the previous one was open against master

src/main/target/RUSHCORE7/target.h Outdated Show resolved Hide resolved
@asizon
Copy link
Member

asizon commented Jan 5, 2019

I think that GYRO1_CS_PIN now works on 3.5

@MJ666
Copy link
Contributor

MJ666 commented Jan 5, 2019

@nyway after checking more in detail @asizon is correct 3.5.x is alredy supporting thenew types of definitions for the Gyro/ACC and is on the step to transition to the new settings. So your definitions most likely working as expected.

Copy link
Member

@mikeller mikeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request system is not intended to be used to find / fix compilation / functional errors. Before opening a pull request for a new target, please make sure that:

  • your target builds;
  • basic function checks succeed, i.e. the target boots, and the acc / gyro works,...

docs/boards/Board - RUSHCORE7.md Outdated Show resolved Hide resolved
src/main/target/RUSHCORE7/target.c Outdated Show resolved Hide resolved
@MJ666
Copy link
Contributor

MJ666 commented Jan 7, 2019

@mikeller my comment was regarding MPU6500_CS_PIN vs. GYRO_1_CS_PIN definitions and related ones. They are both supported in 3.5.x in parallel. For sure generic target need a different PR for the config.

@mikeller
Copy link
Member

mikeller commented Jan 7, 2019

@MJ666: Sorry, my comment wasn't a reply to you, it was addressed at @nyway.

Rush authorization add new target RUSHCORE7.
https://www.rushfpv.com

Update target.c

Update target.h

Change GYRO/ACC define for 3.5.x

Update Board - RUSHCORE7.md

Delete the  pic reference

Update target.mk
@nyway
Copy link
Contributor Author

nyway commented Jan 8, 2019

@mikeller @MJ666
Modification complete and test good so far.Please help me check if there is anything to be modified,thanks.

Copy link
Member

@mikeller mikeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good.

docs/boards/Board - RUSHCORE7.md Show resolved Hide resolved
delete RUSHCORE7 - pic1.jpg and RUSHCORE7 - pic2.jpg
@mikeller
Copy link
Member

@MJ666: Have your concerns with this been addressed?

@MJ666
Copy link
Contributor

MJ666 commented Jan 12, 2019

Looks all good to me.

@mikeller mikeller merged commit 18ff1f7 into betaflight:3.5.x-maintenance Jan 12, 2019
@nyway nyway deleted the 3.5.x-maintenance branch January 12, 2019 10:12
@mikeller
Copy link
Member

Added board description link to wiki.

@mikeller
Copy link
Member

@nyway: Now that the format for Unified Target configurations for Betaflight 4.0 has been defined, and a process to create them established, can you please open a pull request to get this target added to the master branch? Instructions for this can be found at https://github.com/betaflight/betaflight#new-requirements-for-the-submission-of-new-and-updated-targets.

We can do this for you, but since we do not have the actual hardware, this will mean that the target will be untested and potentially broken in 4.0, so it is preferrable if you do this, and test the resulting firmware and Unified Target configuration before submitting the pull request.

@nyway
Copy link
Contributor Author

nyway commented Mar 27, 2019

@mikeller
Okay,i will do that.
Should i do the same thing for the other out target DALRCF405 or 722?

@mikeller
Copy link
Member

@nyway: Those two are already in 4.0 as 'legacy' targets (in src/main/target). But if you could submit them as Universal Target configurations (in universal_targets/configs) that would be great!

mikeller added a commit to mikeller/betaflight that referenced this pull request Apr 7, 2019
Add new target RUSHCORE7

Added target RUSHCORE7 to 4.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants