Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PID and Rate profile names, osd elements and cli config #7696

Merged
merged 1 commit into from
May 7, 2019
Merged

Add PID and Rate profile names, osd elements and cli config #7696

merged 1 commit into from
May 7, 2019

Conversation

pkruger
Copy link
Contributor

@pkruger pkruger commented Mar 2, 2019

Fixes: #5671

@pkruger pkruger mentioned this pull request Mar 2, 2019
Closed
mikeller
mikeller requested changes Mar 2, 2019
View reviewed changes
src/main/fc/config.h Outdated Show resolved Hide resolved
src/main/fc/config.h Outdated Show resolved Hide resolved
src/main/pg/pg_ids.h Outdated Show resolved Hide resolved
src/main/cli/cli.c Outdated Show resolved Hide resolved
src/main/cli/cli.c Outdated Show resolved Hide resolved
@mikeller mikeller added this to the 4.1 milestone Mar 2, 2019
etracer65
etracer65 suggested changes Mar 2, 2019
View reviewed changes
src/main/cli/cli.c Outdated Show resolved Hide resolved
@pkruger pkruger force-pushed the 5671-feature-allow-capturing-of-a-short-description-for-PID-and-Rate-profiles branch from 2a9f784 to 562508d Compare March 2, 2019 13:26
mikeller
mikeller requested changes Mar 2, 2019
View reviewed changes
src/main/cli/cli.c Outdated Show resolved Hide resolved
src/main/osd/osd_elements.c Outdated Show resolved Hide resolved
@pkruger
Copy link
Contributor Author

pkruger commented Mar 2, 2019

Looking into why the build is failing.

@mikeller
Copy link
Member

mikeller commented Mar 2, 2019

It was a bad check in the tests that had been accidentally deactivated and then was reactivated, fixed in #7701. Just rebase / push to get the tests to re-run, and it should be fine.

@pkruger pkruger force-pushed the 5671-feature-allow-capturing-of-a-short-description-for-PID-and-Rate-profiles branch from 562508d to e4649b0 Compare March 3, 2019 02:09
@etracer65 etracer65 mentioned this pull request Mar 3, 2019
Closed
etracer65
etracer65 previously approved these changes Mar 3, 2019
View reviewed changes
mikeller
mikeller previously approved these changes Mar 4, 2019
View reviewed changes
@pkruger pkruger dismissed stale reviews from mikeller and etracer65 via 3da7fcc March 8, 2019 09:58
@mikeller mikeller mentioned this pull request Mar 11, 2019
Merged
@mikeller
Copy link
Member

@pkruger: Can you rebase please?

@pkruger
Copy link
Contributor Author

pkruger commented May 2, 2019

@mikeller Sure, rebase is done. I'll be testing/checking it tonight,should be ready for review and merge soon.

@pkruger
Copy link
Contributor Author

pkruger commented May 2, 2019

@mikeller FYI: I noticed on master that SITL is running out of space:
Creating HEX ./obj/betaflight_4.1.0_SITL.hex
objcopy: obj/betaflight_4.1.0_SITL.hex: address 0x0000000100401000 out of range for Intel Hex file
objcopy:obj/betaflight_4.1.0_SITL.hex: Bad value

@pkruger pkruger force-pushed the 5671-feature-allow-capturing-of-a-short-description-for-PID-and-Rate-profiles branch from 3da7fcc to 6caa95f Compare May 2, 2019 09:38
@mikeller
Copy link
Member

mikeller commented May 2, 2019

@pkruger: That's an interesting failure - I'll have to see what can be done to get around this.

mikeller
mikeller requested changes May 4, 2019
View reviewed changes
src/main/fc/config.h Outdated Show resolved Hide resolved
@pkruger pkruger force-pushed the 5671-feature-allow-capturing-of-a-short-description-for-PID-and-Rate-profiles branch from 21163e9 to 35e6b35 Compare May 5, 2019 06:04
@mikeller
Copy link
Member

mikeller commented May 5, 2019

@pkruger: So sorry, this needs another rebase now.

@pkruger pkruger force-pushed the 5671-feature-allow-capturing-of-a-short-description-for-PID-and-Rate-profiles branch from 35e6b35 to de5a54a Compare May 6, 2019 12:10
@pkruger
Copy link
Contributor Author

pkruger commented May 6, 2019

@mikeller No worries. Rebase done.

@mikeller mikeller merged commit a8f6ea0 into betaflight:master May 7, 2019
@etracer65
Copy link
Member

See #8231

Revises the PID/rate profile names to use standard set and get rather than custom CLI commands. Also eliminates the extra parameter groups and adds the names to the profile or controlRateProfile as appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeller mikeller mikeller approved these changes

@etracer65 etracer65 etracer65 left review comments

Assignees
No one assigned
Labels
RN: IMPROVEMENT
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Allow capturing of a short description for PID and Rate profiles
3 participants
@pkruger @mikeller @etracer65