-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MAMBAF722 Target #8182
Add MAMBAF722 Target #8182
Conversation
set motor_pwm_protocol = DSHOT600 | ||
set current_meter = ADC | ||
set battery_meter = ADC | ||
set system_hse_mhz = 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely not needed for F7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll take out the DSHOT as requested. Diatone will be using their boards mostly in complete drone with DSHOT600 the default so decided to put that in for ease of the consumer.
Question about the others though. These are spit out from the CLI using the instructions given and are settings in the configurator. I’ve checked the other F7 config files and they all seem to have them as well. If I take out the battery/current meter settings and load the board, it sets NONE/VIRTUAL in the configurator. Board has ADC on both and would prefer it set as default as in the legacy target.
EDIT: I deleted DSHOT and HSE and repushed. Will delete ADC pending your response to my questions above. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was only talking about system_hse_mhz
, which is not even used on F7. And you are right, all (or most) Unified Target configs have this at the moment - I'll have to investigate why this is printed in the diff
, since 8 MHz is the default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikeller No worries. My bad for not understanding what you were referring to. Appreciate the response. When I get home from work, I'll add back in the DSHOT per the request of the manufacturer and repush if that works for you. Let me know if I need to clean anything else up. Much appreciated. Great work on the Unified Target concept!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Target change made as required. Thanks.
4d59952
to
89fd57b
Compare
89fd57b
to
3aa3751
Compare
Merged. Is it possible to get engineering samples of this board? |
I understand you are the author of the MambaF7 target? I recently received this board from Diatone and was disappointed to see I2C not configured - although "inner" pads visible on board. Do you intend to define I2C resources so that I2C can be mapped to "external" pads? I have no idea if this is a big ask - I am a real noob when it comes to BF!! I have tried asking Diatone.hk about this but I think we have language problems. I would also like to run this board with BF3.5 and so have tried adding your src/main/target/MAMBAF722 folder to 3.5.7 but get build errors
What do else do I need to do to get your new target to build with 3.5.7? Thanks Neil |
Request addition of the MAMBAF722 Target.
Unified Target config file included as required. Tested and works great.
manufacturer_id DIAT already added a few days ago in preparation for this and other targets.
Thank you in advance.