Fixed problems with bitbanged Dshot and lazily allocated timers. #8861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etracer65
reviewed
Sep 9, 2019
src/main/cli/settings.c
Outdated
| @@ -768,6 +773,7 @@ const clivalue_t valueTable[] = { | |||
| #endif | |||
| #ifdef USE_DSHOT_BITBANG | |||
| { "dshot_bitbang", VAR_UINT8 | MASTER_VALUE | MODE_LOOKUP, .config.lookup = { TABLE_OFF_ON_AUTO }, PG_MOTOR_CONFIG, offsetof(motorConfig_t, dev.useDshotBitbang) }, | |||
| { "dshot_bitbang_timer", VAR_UINT8 | MASTER_VALUE | MODE_LOOKUP, .config.lookup = { TABLE_DSHOT_BITBANGED_TIMER }, PG_MOTOR_CONFIG, offsetof(motorConfig_t, dev.useDshotBitbangedTimer) }, | |||
There was a problem hiding this comment.
Should this potentially be tagged as HARDWARE_VALUE as it seems to be target related?
src/main/pg/motor.c
Outdated
| @@ -76,6 +76,7 @@ void pgResetFn_motorConfig(motorConfig_t *motorConfig) | |||
|
|
|||
| #ifdef USE_DSHOT_BITBANG | |||
| motorConfig->dev.useDshotBitbang = DSHOT_BITBANG_AUTO; | |||
| motorConfig->dev.useDshotBitbangedTimer = DSHOT_BITBANGED_TIMER_AUTO; | |||
There was a problem hiding this comment.
And maybe add the ability to set the default via a target-level define for non-unified targets?
There was a problem hiding this comment.
Gah, I'd hoped to have slain target dependent defines in 4.1. But I guess we still have a handful of non-unified targets so we should still add them.
etracer65
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to use
set dshot_bitbang_timer = [tim1|tim8]to pre-select the timer to be used for bitbanged Dshot. Default isautofor automatic selection.