Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed detection of BMP280 / BME280. #9982

Merged
merged 1 commit into from
Jul 19, 2020
Merged

Fixed detection of BMP280 / BME280. #9982

merged 1 commit into from
Jul 19, 2020

Conversation

mikeller
Copy link
Member

@mikeller mikeller commented Jul 5, 2020

Fix for problem introduced in #9656.

@mikeller mikeller added this to the 4.3 milestone Jul 5, 2020
asizon
asizon approved these changes Jul 19, 2020
View reviewed changes
Copy link
Member

@asizon asizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, just looking for this bug and ready to open another PR for this xd, Please merge it

@asizon
Copy link
Member

asizon commented Jul 19, 2020

Maybe we can fix that in this PR?seems that it need to remove the ","

betaflight/src/main/sensors/barometer.h

Line 35 in 4e2cef0

BARO_DPS310 = 8,

@mikeller mikeller merged commit 6a92bf3 into betaflight:master Jul 19, 2020
@mikeller mikeller deleted the fix_bmp280_detection branch July 19, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@asizon asizon asizon approved these changes

Assignees
No one assigned
Labels
RN: BUGFIX
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeller @asizon @McGiverGim