Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to change coding style so match up with modern code editors? #4

Closed
DusKing1 opened this issue Feb 15, 2020 · 2 comments
Closed
Labels

Comments

@DusKing1
Copy link

The src/BLHeli_S.asm has 4531 lines of code, although from line:559 can be collapsed as code blocks in modern code editors (i.e. vscode), some comments still do not perform the same indentation, making the code reading confusing.

In addition, the recommended tab width is 5, not like betaflight style which is 4.

I cleaned up the code in a way I thought was readable, just do not want to create extra work. If you guys think that's ok, I'll make a PR at a point when you think is appropriate.

@stale
Copy link

stale bot commented Mar 16, 2020

This issue / pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

@stale stale bot added the Inactive label Mar 16, 2020
@stale
Copy link

stale bot commented Mar 24, 2020

Automatically closing as inactive.

@stale stale bot closed this as completed Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant