Fix #33 : Port is now configureable via 'npm config' #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit for a defined file from a repo
commit for a defined file from a repo
…com/sgmap/ludwig into batch_retrieves_initial_file_author
ludwig is creating pull requests to (not automatically master) + Updated documentation and sample configuration file to reflect the fact we don't need the acceptedTestsLocation property anymore
user's Github DisplayName (and connects the user if he is not)
display name (filter now uses the github user id which should be less ambiguous + very stable)
-> removed old way of setting port -> if no port is set, default is still 3000 -> documentation updated to reflect change
…ate format is now the same as in the history page
| @@ -121,6 +121,19 @@ Deux autres paramètres sont configurés par clefs de configuration NPM : | |||
|
|
|||
| Pour automatiser l'enregistrement de toutes les clefs de configuration npm, un script est disponible dans `./scripts/setupNPMVariables.sh`. Cela reste partiellement manuel mais aucune clef n'est oubliée et cela devrait éviter les fautes de frappe. | |||
|
|
|||
| #### Autres options de configuration | |||
|
|
|||
| Il est possible de configurer le port que va utiliser le serveur Ludwig. Par défaut, ludwig se lancera éécoutera sur le port `3000`. Cependant, il est possible de définir le port que vous souhaitez en configurant la clef `ludwig:port` par npm config. | |||
There was a problem hiding this comment.
« se lancera éécoutera » 😉
npm config (avec les ```)
- Removed callbacks in xUnitParser in favor of promises - Renamed parsed.js into testSuiteParserUtils.js to try an better convey intent - renamed methods in parsed.js to better convey intent too - various refactors to try and not mix operations (checking vs building) in xUnitParser.parse
Renamed the configuration object to make it more explicit that the configuration needed by the testResultsCollector is the app's configuration
There is no need for GithubHelper & XUnitParser to be instantiated each time the collector needs them.
Created a DAO to try and better separate concerns and have a testResultsCollector that only manipulates data and does not get into mongodb internals
We don't need to explicitly assign some of the elements of the callback call in the collectTestHistoryDataForTest for now. Shorthand assignations will do the job
testService does not have another purpose than to wrap database calls, we might as well use the dedicated DAO to do this
It is not needed right now
Explicitly setting userIdFilter at the beginning of the listTests handler is not mandatory.
+ reformatted a bit githubHelper
- also refactored getSystemOutputsForTests to try to better reveal intent
- the aim of this is to avoid making tons of call to the github API and trigger abuse mechanisms - at the moment, the most likely way to trigger githubs abuse mechanisms is when importing test results - githelper aims to try and do most of the "data intensive" work (like getting initial commiter info) offline on a cloned app repo, instead of systematically make calls to the github API - this should avoid triggering rate-limit based errors
- App does not rely on GH API for commit history anymore (local checkout & exploration) - Metadata comes solely from git logs - Filter in the GUI filter based on email / github login / github display name (not GH id)
- It should not be possible to start processing the contents of a repo if it's not finished cloning / updating anymore - Changed the tests around (and the gitHelper) to allow testing of the simpleGit configuration at each call
Batch retrieves initial file author + author is displayed in list ...
Limit GitHub api calls
- Function to send data to ludwig now uses the default formatter and can use a custom one - Modified the test.ejs template to give a json object for expected data
- Widget is now able to POST a suggestion (vanilla JS workflow w/ form creation in the DOM + post called on it) - form added to the DOM is checked for presence and removed if need be - Added a route to handle the post that works like the get one - Updated example template to use POST to create a PR from the ludwig server - Updated documentation to reflect the new widget API
- mostly by using imports instead or requires and getting rid or var statements
ES6-ify server.js
- search now properly uses GitHub API to search for a single reference (and not get whatever random of list of references is returned first by the API). - no more actual search logic supported by the helper, everything is delegated to the GitHub API
…erence Fix githelper gets exact branch reference
- Function to send data to ludwig now uses the default formatter and can use a custom one - Modified the test.ejs template to give a json object for expected data
- Widget is now able to POST a suggestion (vanilla JS workflow w/ form creation in the DOM + post called on it) - form added to the DOM is checked for presence and removed if need be - Added a route to handle the post that works like the get one - Updated example template to use POST to create a PR from the ludwig server - Updated documentation to reflect the new widget API
…gmap/ludwig into widget_update_custom_format_for_ludwig
Widget update custom format for ludwig
-> removed old way of setting port -> if no port is set, default is still 3000 -> documentation updated to reflect change
- Removed duplicate section about port config - Removed typos in port config section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> removed old way of setting port
-> if no port is set, default is still 3000
-> documentation updated to reflect change
This should fix #33