Fix #39 Widget asks for a domain name not a path #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed conf so that the conf asked limits itself to the relevant part (domain) * if /createSuggestion suffix is provided, even though not necessary anymore, it's not appended again * updated documentation to fit new behavior * added a default domain value that is set to 'http://localhost:3000'
| @@ -11,7 +11,13 @@ class Ludwig { | |||
| this.branch = configuration.branch || 'master'; | |||
| this.template = configuration.template; | |||
| this.prefix = configuration.prefix; | |||
| this.ludwigCreateSuggestionURL = configuration.ludwigCreateSuggestionURL; | |||
| const suggestionDomain = configuration.ludwigCreateSuggestionDomain? configuration.ludwigCreateSuggestionDomain : 'http://localhost:3000'; | |||
There was a problem hiding this comment.
Wouldn't it be more debuggable to fail if it is not set, and ensure the defaults are set in the config itself?
|
Too old, closing. @guillett if you want to revive this work, feel free to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(domain)
anymore, it's not appended again