Hot fix : améliorer la perf de la page "mes cantines" #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qloridant
reviewed
May 27, 2024
| "central_kitchen_diagnostics", # can return a TD status instead of diagnostics | ||
| ) | ||
| fields = my_fields | ||
| read_only_fields = my_fields |
There was a problem hiding this comment.
On ne peut pas directement écrire read_only_fields = (... ) ?
There was a problem hiding this comment.
comme
fields = ("id", "name",...)
read_only_fields = ("id", "name",...)
?
Oui on peut, je n'aime pas la repetition
qloridant
approved these changes
May 29, 2024
qloridant
reviewed
May 29, 2024
|
|
||
| class Meta: | ||
| model = Canteen | ||
| my_fields = ( |
There was a problem hiding this comment.
Suggested change
| my_fields = ( | |
| read_only_fields = ( | |
| "id", | |
| "name", | |
| "city", | |
| "city_insee_code", | |
| "postal_code", | |
| "sectors", | |
| "daily_meal_count", | |
| "yearly_meal_count", | |
| "siret", | |
| "management_type", | |
| "production_type", | |
| "department", | |
| "region", | |
| "publication_status", | |
| "economic_model", | |
| "is_central_cuisine", | |
| "modification_date", | |
| # the following can still be improved | |
| "images", # can return the first image only | |
| "diagnostics", | |
| "central_kitchen_diagnostics", # can return a TD status instead of diagnostics | |
| ) |
alemangui
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suite à une PR qui a ajouté quelques champs complèxes sur le
FullCanteenSerializer, il y a un interêt d'avoir un nouveau endpoint pour la pagination des cantines. Sur staging je c'est bcp trop lente.Avant : 1.68s; après : 138 ms
idéalement on fera en deuxième temps une refacto des serializers et endpoints pour voir lesquels on pourrait merger, quoi on a qui est maintenant redondant #3956