-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot fix : améliorer la perf de la page "mes cantines" #3955
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -365,6 +365,62 @@ def get_central_kitchen_diagnostics(self, obj): | |
return None | ||
|
||
|
||
class CanteenSummarySerializer(serializers.ModelSerializer): | ||
images = MediaListSerializer(child=CanteenImageSerializer(), required=False) | ||
diagnostics = FullDiagnosticSerializer(many=True, read_only=True, source="diagnostic_set") | ||
central_kitchen_diagnostics = serializers.SerializerMethodField(read_only=True) | ||
|
||
class Meta: | ||
model = Canteen | ||
my_fields = ( | ||
"id", | ||
"name", | ||
"city", | ||
"city_insee_code", | ||
"postal_code", | ||
"sectors", | ||
"daily_meal_count", | ||
"yearly_meal_count", | ||
"siret", | ||
"management_type", | ||
"production_type", | ||
"department", | ||
"region", | ||
"publication_status", | ||
"economic_model", | ||
"is_central_cuisine", | ||
"modification_date", | ||
# the following can still be improved | ||
"images", # can return the first image only | ||
"diagnostics", | ||
"central_kitchen_diagnostics", # can return a TD status instead of diagnostics | ||
) | ||
fields = my_fields | ||
read_only_fields = my_fields | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. On ne peut pas directement écrire read_only_fields = (... ) ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. comme
? |
||
|
||
def get_central_kitchen_diagnostics(self, obj): | ||
# Ideally we would also check the status of the satellite canteen and | ||
# the central cuisine, for now we omit this check. For now it is the | ||
# responsibility of the frontend to use this information. | ||
if not obj.central_producer_siret or not obj.production_type == Canteen.ProductionType.ON_SITE_CENTRAL: | ||
return None | ||
try: | ||
diagnostics = Diagnostic.objects.filter( | ||
canteen__siret=obj.central_producer_siret, | ||
central_kitchen_diagnostic_mode__in=[ | ||
Diagnostic.CentralKitchenDiagnosticMode.ALL, | ||
Diagnostic.CentralKitchenDiagnosticMode.APPRO, | ||
], | ||
) | ||
|
||
return CentralKitchenDiagnosticSerializer(diagnostics, many=True).data | ||
except Canteen.DoesNotExist: | ||
return None | ||
except Canteen.MultipleObjectsReturned as e: | ||
logger.exception(f"Multiple canteens returned when obtaining the central_producer_siret field {e}") | ||
return None | ||
|
||
|
||
class CanteenPreviewSerializer(serializers.ModelSerializer): | ||
class Meta: | ||
model = Canteen | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.