Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

280 add region academy #165

Merged
merged 12 commits into from
Apr 5, 2024
Merged

280 add region academy #165

merged 12 commits into from
Apr 5, 2024

Conversation

pierrax
Copy link
Collaborator

@pierrax pierrax commented Apr 5, 2024

No description provided.

@pierrax pierrax temporarily deployed to ms2gt-280-add-region-ac-rlgdgm April 5, 2024 07:42 Inactive
@pierrax pierrax temporarily deployed to ms2gt-280-add-region-ac-rlgdgm April 5, 2024 11:55 Inactive
@pierrax pierrax temporarily deployed to ms2gt-280-add-region-ac-rlgdgm April 5, 2024 12:04 Inactive
@pierrax pierrax temporarily deployed to ms2gt-280-add-region-ac-rlgdgm April 5, 2024 12:10 Inactive
@pierrax pierrax temporarily deployed to ms2gt-280-add-region-ac-rlgdgm April 5, 2024 12:41 Inactive
@pierrax pierrax temporarily deployed to ms2gt-280-add-region-ac-rlgdgm April 5, 2024 13:37 Inactive
Copy link
Collaborator

@fitchMitch fitchMitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plusieurs questions

app/models/academy.rb Outdated Show resolved Hide resolved
app/models/academy.rb Show resolved Hide resolved
app/models/school.rb Outdated Show resolved Hide resolved
app/models/academy_region.rb Outdated Show resolved Hide resolved

def custom_dashboard_path
url_helpers.root_path
# url_helpers.reporting_dashboards_path(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

les commnetaires , c'est pour appliquer plus tard ? ou c'est un essai ?

t.string :email_domain
t.integer :academy_region_id

t.timestamps
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timestamps pas forcément très utiles, mais , on s'en moque un peu

db/migrate/20240403131643_add_academy_to_departments.rb Outdated Show resolved Hide resolved
db/migrate/20240404071148_add_academy_to_statisticians.rb Outdated Show resolved Hide resolved
app/models/school.rb Outdated Show resolved Hide resolved
test/factories/schools.rb Outdated Show resolved Hide resolved
@pierrax pierrax temporarily deployed to ms2gt-280-add-region-ac-rlgdgm April 5, 2024 13:58 Inactive
@pierrax pierrax merged commit 965dd37 into review Apr 5, 2024
1 of 2 checks passed
@pierrax pierrax deleted the 280_add_region_academy branch April 5, 2024 14:16
@pierrax pierrax temporarily deployed to ms2gt-280-add-region-ac-rlgdgm April 5, 2024 14:16 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants