A couple of small fixes for the 7.1 beta #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rzubek
commented
Jun 18, 2023
rzubek
commented
- One JSON name annotation was missing
- Small fix for streamed argument string reconstruction: it assumed that the first arguments chunk was going to be an empty string, which has been empirically true so far, but might not be in the future.
7.1.0 -beta
… and we only perform appending on subsequent blocks. The prior version (without this change) risked doubling up the first argument string. It doesn't happened in practice, because ChatGPT's first streaming message has an empty arguments string (i.e. `"arguments": ""`), so doubling up an empty string had no effect. But let's fix this just in case their implementation changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.