Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu items are annoying #125

Open
bethlakshmi opened this issue Dec 13, 2013 · 6 comments
Open

Menu items are annoying #125

bethlakshmi opened this issue Dec 13, 2013 · 6 comments

Comments

@bethlakshmi
Copy link
Owner

  • still no way to have people click on menu items and not get redirected to the first item in the submenu. This is an ugly design change - if you want a fast answer, send me a default landing page for each menu item. If not, I'll keep it on the list and get to it as time allows.

Ideally the menu sidebar would be separate in how it's displayed from the action on the main page. It could be redesigned as an additional value appended to the current link, rather than as a new URL submission, but that's not at all how it's coded. The current method is rather annoying, since you can easily end up loading and reloading uninteresting pages.

@bethlakshmi
Copy link
Owner Author

I will take this one as time allows, but I REALLY wouldn't mind it getting taken off my hands.

@jonkiparsky
Copy link
Collaborator

Thinking aloud about this one, it seems that the best solution might be to generate all submenus on page load with approriate class tags and use jquery to hide and show them. This would avoid the reload problem, and the associated db calls.
The jquery is pretty simple, if the class tags are there, since it selects by classes just as css does.

However, I haven't looked at the code that generates the left nav, so I don't know whether it's amenable to modification.

@bethlakshmi
Copy link
Owner Author

You've seen a lot of the other code. :)

They've got a class infrastructure of different types of menu items but
it's not particularly elegant. The kicker right now is that the way that
it decides what menu to open is based on what the current URL is of the
page - it opens whatever submenu has an item with an exact match in it.
There's no infrastructure there for defining menu choice as different from
current page.

Given how many navigation choices are hidden in the body of the code, and
how easily we could brake it, I just feel cautious about doing anything
without some serious thought.

jquery would be cool to learn, I know it's super useful, but it will be a
minor learning curve for me.

On Fri, Dec 13, 2013 at 11:21 AM, Jon Kiparsky notifications@github.comwrote:

Thinking aloud about this one, it seems that the best solution might be to
generate all submenus on page load with approriate class tags and use
jquery to hide and show them. This would avoid the reload problem, and the
associated db calls.
The jquery is pretty simple, if the class tags are there, since it selects
by classes just as css does.

However, I haven't looked at the code that generates the left nav, so I
don't know whether it's amenable to modification.


Reply to this email directly or view it on GitHubhttps://github.com//issues/125#issuecomment-30521644
.

@jonkiparsky
Copy link
Collaborator

I've got a little jquery and javascript. If you want to talk this one over,
give me a shout over the weekend. The hard part will be the PHP.

On Fri, Dec 13, 2013 at 4:16 PM, bethlakshmi notifications@github.comwrote:

You've seen a lot of the other code. :)

They've got a class infrastructure of different types of menu items but
it's not particularly elegant. The kicker right now is that the way that
it decides what menu to open is based on what the current URL is of the
page - it opens whatever submenu has an item with an exact match in it.
There's no infrastructure there for defining menu choice as different from
current page.

Given how many navigation choices are hidden in the body of the code, and
how easily we could brake it, I just feel cautious about doing anything
without some serious thought.

jquery would be cool to learn, I know it's super useful, but it will be a
minor learning curve for me.

On Fri, Dec 13, 2013 at 11:21 AM, Jon Kiparsky notifications@github.comwrote:

Thinking aloud about this one, it seems that the best solution might be
to
generate all submenus on page load with approriate class tags and use
jquery to hide and show them. This would avoid the reload problem, and
the
associated db calls.
The jquery is pretty simple, if the class tags are there, since it
selects
by classes just as css does.

However, I haven't looked at the code that generates the left nav, so I
don't know whether it's amenable to modification.


Reply to this email directly or view it on GitHub<
https://github.com/bethlakshmi/GBE/issues/125#issuecomment-30521644>
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/125#issuecomment-30544203
.

@bethlakshmi
Copy link
Owner Author

Tackling other stuff first.

On Fri, Dec 13, 2013 at 4:28 PM, Jon Kiparsky notifications@github.comwrote:

I've got a little jquery and javascript. If you want to talk this one
over,
give me a shout over the weekend. The hard part will be the PHP.

On Fri, Dec 13, 2013 at 4:16 PM, bethlakshmi notifications@github.comwrote:

You've seen a lot of the other code. :)

They've got a class infrastructure of different types of menu items but
it's not particularly elegant. The kicker right now is that the way that
it decides what menu to open is based on what the current URL is of the
page - it opens whatever submenu has an item with an exact match in it.
There's no infrastructure there for defining menu choice as different
from
current page.

Given how many navigation choices are hidden in the body of the code,
and
how easily we could brake it, I just feel cautious about doing anything
without some serious thought.

jquery would be cool to learn, I know it's super useful, but it will be
a
minor learning curve for me.

On Fri, Dec 13, 2013 at 11:21 AM, Jon Kiparsky notifications@github.comwrote:

Thinking aloud about this one, it seems that the best solution might
be
to
generate all submenus on page load with approriate class tags and use
jquery to hide and show them. This would avoid the reload problem, and
the
associated db calls.
The jquery is pretty simple, if the class tags are there, since it
selects
by classes just as css does.

However, I haven't looked at the code that generates the left nav, so
I
don't know whether it's amenable to modification.


Reply to this email directly or view it on GitHub<
https://github.com/bethlakshmi/GBE/issues/125#issuecomment-30521644>
.


Reply to this email directly or view it on GitHub<
https://github.com/bethlakshmi/GBE/issues/125#issuecomment-30544203>
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/125#issuecomment-30545018
.

@jonkiparsky
Copy link
Collaborator

Looking at the code, this might actually be easier than I'd thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants