Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite regression to use tensorflow #10

Merged
merged 1 commit into from
Feb 19, 2018
Merged

Conversation

erikbern
Copy link
Contributor

Turns out tensorflow has implementations of the regularized incomplete gamma functions (tf.igamma) and all kinds of goodies that are already built with automatic differentiation and numeric stability and all that jazz.

Using a SGD-style optimizer also makes it a lot easier to use minibatches and stuff like that for large datasets.

Was pretty surprised how easy this was... did it in less than 2h (this is the first time ever using tensorflow too)

@erikbern
Copy link
Contributor Author

erikbern commented Feb 19, 2018

Plan forward

  • merge this
  • use this for some experiments at work and make sure the gamma implementation works
  • figure out what to do with the kaplan-meier model
  • drop all old models in __init__.py and replace with regression models

@coveralls
Copy link

coveralls commented Feb 19, 2018

Coverage Status

Coverage increased (+1.3%) to 70.233% when pulling 40c84aa on regression-tensorflow into 2dbc6d8 on master.

@erikbern erikbern merged commit 9033f7d into master Feb 19, 2018
@erikbern erikbern deleted the regression-tensorflow branch February 19, 2018 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants