Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make get_arrays return a numpy matrix for features #107

Merged
merged 2 commits into from
Sep 1, 2019

Conversation

erikbern
Copy link
Contributor

@erikbern erikbern commented Sep 1, 2019

fixing a number of smaller issues i encountered while trying to make decision trees work

test_convoys.py Outdated
@@ -241,6 +241,14 @@ def test_convert_dataframe():
# TODO: assert things


def test_convert_dataframe_features(n=1000):
df = _generate_dataframe(n=n)
df['features'] = [tuple(numpy.random.randn() for z in range(3)) for g in df['group']]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (89 > 79 characters)

@coveralls
Copy link

coveralls commented Sep 1, 2019

Coverage Status

Coverage increased (+1.3%) to 96.791% when pulling 4c62fd6 on features-numpy-matrix into d6187b6 on master.

@erikbern erikbern merged commit 263690c into master Sep 1, 2019
@erikbern erikbern deleted the features-numpy-matrix branch September 1, 2019 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants