Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up plotting using numpy #129

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Conversation

adsglass
Copy link
Contributor

@adsglass adsglass commented Jun 3, 2020

Just replaced the slow TODOs with some optimized numpy operations to speed up the plotting.

For a group size of 4 on the little snippet of code before the if ci..., the time taken on the loop improves from 248 ms ± 3.14 ms per loop to 960 µs ± 14.2 µs per loop. All unit tests pass.

@coveralls
Copy link

coveralls commented Jun 3, 2020

Coverage Status

Coverage remained the same at 94.988% when pulling 8a4905e on adsglass:speed-up-plotting into 683e08c on better:master.

@adsglass adsglass closed this Jun 3, 2020
@adsglass adsglass reopened this Jun 3, 2020
@erikbern
Copy link
Contributor

erikbern commented Jun 3, 2020

nice! thanks @adsglass

@erikbern erikbern merged commit 99e832d into better:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants