Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc updates #72

Merged
merged 4 commits into from
Sep 6, 2018
Merged

Minor doc updates #72

merged 4 commits into from
Sep 6, 2018

Conversation

erikbern
Copy link
Contributor

@erikbern erikbern commented Sep 6, 2018

No description provided.


where :math:`\\gamma(a, x)` is the `lower regularized incomplete
gamma function
where :math:`P(a, x) = \\gamma(a, x) / \\Gamma(a)` is the `lower regularized

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (80 > 79 characters)


where :math:`\\gamma(a, x)` is the `lower regularized incomplete
gamma function
where :math:`P(a, x) = \\gamma(a, x) / \\Gamma(a)` is the `lower regularized

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (80 > 79 characters)

@@ -67,21 +67,22 @@ class GeneralizedGamma(RegressionModel):

This mostly follows the `Wikipedia article
<https://en.wikipedia.org/wiki/Generalized_gamma_distribution>`_, although
our notation is slightly different:
our notation is slightly different. Also see `this paper
<http://data.princeton.edu/pop509/ParametricSurvival.pdf>`_ for an overview.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (80 > 79 characters)

@coveralls
Copy link

coveralls commented Sep 6, 2018

Coverage Status

Coverage remained the same at 94.848% when pulling b77d491 on doc-fix into 3e8c681 on master.

<https://docs.scipy.org/doc/scipy/reference/generated/scipy.special.gammainc.html>`_.
where :math:`P(a, x) = \\gamma(a, x) / \\Gamma(a)` is the lower regularized
incomplete gamma function. See :meth:`convoys.gamma.gammainc`.
:math:`\\gamma(a, x)` is the incomplete gamma function and :math:`\\Gamma(a)`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (81 > 79 characters)


There are two problems with autograd.scipy.special.gammainc:
We rely on `scipy.special.gammainc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace

@erikbern erikbern merged commit b5f7ef7 into master Sep 6, 2018
@erikbern erikbern deleted the doc-fix branch September 6, 2018 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants