-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix l2cap segmentation error in concurrent subscription #28
base: master
Are you sure you want to change the base?
Fix l2cap segmentation error in concurrent subscription #28
Commits on Jul 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8e0131e - Browse repository at this point
Copy the full SHA 8e0131eView commit details
Commits on Jul 2, 2021
-
Implement processing of L2CAP Connection Parameter Update Requests.
This checks that the request is valid, replies to the other side in any event (with an accept/reject) and, if accepted, also updates the connection parameters to HCI.
Configuration menu - View commit details
-
Copy full SHA for cf1e810 - Browse repository at this point
Copy the full SHA cf1e810View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34cfe1a - Browse repository at this point
Copy the full SHA 34cfe1aView commit details
Commits on Jul 4, 2021
-
Fix concurrency bug: when unmarshalling an aclData package, we need t…
…o copy the data buffer. The bug that otherwise happens is: 1. HCI.mainLoop gets a byte buffer, reads into it, calls handlePacket 2. handlePacket calls handleL2CAP, which unmarshals into an aclData. This aclData references the original b slice 3. handleL2CAP adds the aclData to a channel 4. handlePacket returns the buffer to the pool 5. Repeat from 1, getting the same buffer _while the aclData referencing it is still in the channel_ Triggering this needs a relatively high data rate, but was possible repeatedly for me with a Polar H10.
Configuration menu - View commit details
-
Copy full SHA for c8f9e41 - Browse repository at this point
Copy the full SHA c8f9e41View commit details -
Complete forking: import Jon-Bright/gatt everywhere rather than bette…
…rcap/gatt. NB: I still intend to drop this fork once I've got everything that I want working and any resulting pull requests to bettercap are merged.
Configuration menu - View commit details
-
Copy full SHA for b3e8270 - Browse repository at this point
Copy the full SHA b3e8270View commit details
Commits on Jul 5, 2021
-
Add missing bounds check. The caller is checking for four bytes, the …
…callee is checking for six bytes, but nobody was checking for 5 bytes :)
Configuration menu - View commit details
-
Copy full SHA for 2b00d6e - Browse repository at this point
Copy the full SHA 2b00d6eView commit details
Commits on Sep 29, 2021
-
Your Name committed
Sep 29, 2021 Configuration menu - View commit details
-
Copy full SHA for a7a36b9 - Browse repository at this point
Copy the full SHA a7a36b9View commit details -
Your Name committed
Sep 29, 2021 Configuration menu - View commit details
-
Copy full SHA for eac68dd - Browse repository at this point
Copy the full SHA eac68ddView commit details -
Your Name committed
Sep 29, 2021 Configuration menu - View commit details
-
Copy full SHA for 74a3e17 - Browse repository at this point
Copy the full SHA 74a3e17View commit details -
Your Name committed
Sep 29, 2021 Configuration menu - View commit details
-
Copy full SHA for 4684463 - Browse repository at this point
Copy the full SHA 4684463View commit details
Commits on Apr 20, 2022
-
Fix l2cap segmentation error in concurrent subscription: Protect segm…
…ent sending in l2cap.conn.write to avoid sending unordered segments for the same l2cap channel
Configuration menu - View commit details
-
Copy full SHA for edd7ec2 - Browse repository at this point
Copy the full SHA edd7ec2View commit details