Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browserify compatibility #13

Merged
merged 4 commits into from
Dec 3, 2014
Merged

Browserify compatibility #13

merged 4 commits into from
Dec 3, 2014

Conversation

DigitalIO
Copy link
Contributor

oauth-signature-js checks if a "window" global object exists to determine if it is running in the browser. While this works alone, it does not work when in conjunction with Browserify.

Browserify emulates Node's "module" global to properly expose objects. In order to work with Browserify (or Node "emulation") I modified the isNode flag to check for the non-existence of the module and module.exports global, instead of checking for the existence of the window global.

I don't know of a simple way to test that the code works with browserify and the current code does not. I added a test to prove that the "old" and "new" method of detection both return the same value when tested in the browser or in Node. Thus, no current implementations should be hindered by the update.

@bettiolo
Copy link
Owner

bettiolo commented Dec 3, 2014

Probably I didn't explain myself well, I was suggesting a test that demonstrates the usage of browserify.

bettiolo added a commit that referenced this pull request Dec 3, 2014
@bettiolo bettiolo merged commit 4657f08 into bettiolo:master Dec 3, 2014
This was referenced Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants