Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oauth-signature-js checks if a "window" global object exists to determine if it is running in the browser. While this works alone, it does not work when in conjunction with Browserify.
Browserify emulates Node's "module" global to properly expose objects. In order to work with Browserify (or Node "emulation") I modified the isNode flag to check for the non-existence of the module and module.exports global, instead of checking for the existence of the window global.
I don't know of a simple way to test that the code works with browserify and the current code does not. I added a test to prove that the "old" and "new" method of detection both return the same value when tested in the browser or in Node. Thus, no current implementations should be hindered by the update.