-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Bevy of birds are migrating south for the summer #1398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't believe this is a breaking change because all of the deregistered types were covered by recursive type registration. This may need confirmation, though.
BD103
added
C-Content
A-Migration Guides
S-Needs-Review
X-Uncontroversial
This work is generally agreed upon
labels
Jun 13, 2024
This was referenced Jun 13, 2024
rparrett
reviewed
Jun 13, 2024
release-content/0.14/migration-guides/12234_Move_commands_module_into_bevyecsworld.md
Outdated
Show resolved
Hide resolved
rparrett
reviewed
Jun 13, 2024
release-content/0.14/migration-guides/12234_Move_commands_module_into_bevyecsworld.md
Outdated
Show resolved
Hide resolved
rparrett
reviewed
Jun 13, 2024
release-content/0.14/migration-guides/12314_Clean_up_type_registrations.md
Show resolved
Hide resolved
|
rparrett
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed one small punctuation issue, but lgtm.
release-content/0.14/migration-guides/13159_Improve_tracing_layer_customization.md
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another round of migration guides! (Part of #1396.)
@james7132, would you mind confirming that I was correct in removing bevyengine/bevy#12314 from the migration guide? It would only be a breaking change if it no longer registered a type that was registered previously. (Non-blocking, though, if you don't find the time for this!)