Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Bevy of birds are migrating south for the summer #1398

Merged
merged 13 commits into from
Jun 19, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Jun 13, 2024

Another round of migration guides! (Part of #1396.)

@james7132, would you mind confirming that I was correct in removing bevyengine/bevy#12314 from the migration guide? It would only be a breaking change if it no longer registered a type that was registered previously. (Non-blocking, though, if you don't find the time for this!)

I don't believe this is a breaking change because all of the deregistered types were covered by recursive type registration. This may need confirmation, though.
@BD103
Copy link
Member Author

BD103 commented Jun 13, 2024

CI is breakage is unrelated, due to #1399.

Copy link
Contributor

@rparrett rparrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed one small punctuation issue, but lgtm.

Merged via the queue into bevyengine:main with commit ac4a237 Jun 19, 2024
10 checks passed
@BD103 BD103 deleted the migration-guide-5 branch June 19, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants