Plugin guidelines makeover #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Jan 14, 2024
|
@TrialDragon could I get your review here? |
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
NthTensor
approved these changes
Jan 14, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #853
I reworked this section, de-nesting the list and hopefully using language that's a bit clearer. I also added a link off to cargo's feature docs.
Fixes #855
I converted this table into a list, similar to how these fields are listed in the cargo docs. The workaround used in another table of placing html header specifying a particular pixel width was quite janky (not responsive to various browser font sizes).
I also tried removing the word-breaking from the tables, but I'm pretty sure this would break other tables, especially on mobile.
Fixes #856
Straightforward.
Fixes #857
I reworked this section to not use a table because the table was hopelessly broken on mobile. It was showing an entire screen's worth of blank space between the badges. We should really be testing these pages on mobile.
I removed the "badge descriptions" that were in the table, but added similar text to the alt tags of the badges themselves. This is pretty visible and I think it should be pretty clear what's going on.
Here's a side-by-side before-and-after: before-after-plugin-guidelines.png
Fixes #858
Straightforward.