Move bevy_math's implementations of Reflect into bevy_math
#13456
Labels
A-Math
Fundamental domain-agnostic mathematical operations
A-Reflection
Runtime information about types
C-Enhancement
A new feature
D-Straightforward
Simple bug fixes and API improvements, docs, test and examples
Comments
mweatherley
added
C-Enhancement
MrGVSV
added
A-Reflection
|
I will get started on moving these implementations. |
github-merge-queue bot
pushed a commit
that referenced
this issue
May 27, 2024
# Objective Fixes #13456 ## Solution Moved `bevy_math`'s `Reflect` impls from `bevy_reflect` to `bevy_math`. ### Quick note I accidentally used the same commit message while resolving a merge conflict (first time I had to resolve a conflict). Sorry about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does this solve or what need does it fill?
Right now,
bevy_math's implementations ofReflectall live inbevy_reflectbehind an optional feature flag. The problem with this is that it relies on the fact that all of the reflected types so far have no private fields. Private fields are inaccessible frombevy_reflect, so this organizational choice places limitations indirectly on data inbevy_math.I ran into this limitation while working on curve-based animation.
What solution would you like?
bevy_mathshould provide its ownReflectimplementations behind an optional dependency onbevy_reflect. This makes more sense practically and organizationally, sincebevy_mathactually owns those types and has access to their private data.What alternative(s) have you considered?
Make all fields of all
bevy_mathtypes withReflectpublic forever.The text was updated successfully, but these errors were encountered: