Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary ResMut in examples #10879

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Remove unnecessary ResMut in examples #10879

merged 1 commit into from
Dec 5, 2023

Conversation

akimakinai
Copy link
Contributor

Objective

  • Examples containing ResMuts that are never mutated can be confusing for readers.

Solution

  • Changes them to Res.

nicopap
nicopap approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@nicopap nicopap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@nicopap nicopap added A-ECS Entities, components, systems, and events C-Examples An addition or correction to our examples C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Dec 5, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 5, 2023
Merged via the queue into bevyengine:main with commit f90248b Dec 5, 2023
27 checks passed
@akimakinai akimakinai deleted the resmut branch December 5, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@nicopap nicopap nicopap approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akimakinai @nicopap @tim-blackbird @alice-i-cecile