Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace calculation with function call #11077

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Replace calculation with function call #11077

merged 1 commit into from
Dec 23, 2023

Conversation

tygyh
Copy link
Contributor

@tygyh tygyh commented Dec 23, 2023

Objective

  • Simplify execution.

Solution

  • Replace degrees to radians calculation with function call.

@rparrett
Copy link
Contributor

rparrett commented Dec 23, 2023 •
edited
Loading

What is the status of #9050? The same manual math is being done there (but at least uses PI).

Energy spent improving this code might be better spent reviewing / advancing that PR.

@james7132 james7132 added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change labels Dec 23, 2023
james7132
james7132 approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a single line change, though I agree the improvement should also be mirrored there too.

@james7132 james7132 added this pull request to the merge queue Dec 23, 2023
Merged via the queue into bevyengine:main with commit 22acd62 Dec 23, 2023
25 checks passed
@tygyh tygyh deleted the Simplify-expression branch December 25, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tygyh @rparrett @james7132