Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix B0003 example and update logs #11162

Merged
merged 7 commits into from
Jan 10, 2024
Merged

fix B0003 example and update logs #11162

merged 7 commits into from
Jan 10, 2024

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Update the example code so that is always fail
  • Also update logs and instructions on how to debug as it's easier now

@mockersf mockersf added the A-ECS Entities, components, systems, and events label Dec 31, 2023
@alice-i-cecile alice-i-cecile added the C-Docs An addition or correction to our documentation label Dec 31, 2023
@alice-i-cecile alice-i-cecile added this to the 0.13 milestone Dec 31, 2023
alice-i-cecile
alice-i-cecile reviewed Jan 1, 2024
View reviewed changes
errors/B0003.md Outdated Show resolved Hide resolved
alice-i-cecile
alice-i-cecile approved these changes Jan 1, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar nit, but LGTM.

@mockersf @alice-i-cecile
Update B0003.md
4587834 
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
@doonv doonv mentioned this pull request Jan 1, 2024
Merged
@alice-i-cecile
Copy link
Member

@doonv @killercup could I get a review from one or both of you?

doonv
doonv reviewed Jan 1, 2024
View reviewed changes
errors/B0003.md Outdated Show resolved Hide resolved
errors/B0003.md Outdated Show resolved Hide resolved
errors/B0003.md Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 10, 2024
@alice-i-cecile
Copy link
Member

@mockersf go ahead and merge this once CI is green.

@mockersf
Revert "tuple"
a289a9f 
This reverts commit cea4809.
@mockersf mockersf added this pull request to the merge queue Jan 10, 2024
Merged via the queue into bevyengine:main with commit d4ffd4f Jan 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doonv doonv doonv approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @alice-i-cecile @doonv