Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when bevy_sprite and bevy_pbr are not enabled with bevy_gizmos #11296

Merged
merged 3 commits into from
Jan 14, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Jan 11, 2024

Objective

Solution

  • Log an error message when GizmoPlugin is registered.

Alternatives

I chose to log an error message, since it seemed the least intrusive of potential solutions. Some alternatives include:


Changelog

  • bevy_gizmos will now log an error if neither bevy_pbr nor bevy_sprite are enabled.

@BD103
Copy link
Member Author

BD103 commented Jan 11, 2024

I tested this commit using this Gist.

Copy link
Contributor

@doonv doonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. still have a few minor nitpicks tho

crates/bevy_gizmos/src/lib.rs Outdated Show resolved Hide resolved
crates/bevy_gizmos/src/lib.rs Outdated Show resolved Hide resolved
@alice-i-cecile
Copy link
Member

This is an example of the problems caused by the lack of plugin dependencies (#69). I'm not sure we'll land that this cycle, despite the hard work of @NthTensor, so I'm alright to merge this for now.

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Gizmos Visual editor and debug gizmos labels Jan 11, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 14, 2024
Merged via the queue into bevyengine:main with commit b2d417b Jan 14, 2024
29 checks passed
@BD103 BD103 deleted the gizmo-warn branch January 14, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Gizmos Visual editor and debug gizmos C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using bevy_gizmos feature with default-features=false renders nothing (requires extra bevy_pbr feature)
3 participants