Fix embedded watcher to work with external crates #11370
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Tried using "embedded_watcher" feature and
embedded_asset!()
from another crate. The assets embedded fine but were not "watched." The problem appears to be that checking for the feature was done inside the macro, so rather than checking if "embedded_watcher" was enabled for bevy, it would check if it was enabled for the current crate.Solution
I extracted the checks for the "embedded_watcher" feature into its own function called
watched_path()
. No external changes.Alternative Solution
An alternative fix would be to not do any feature checking in
embedded_asset!()
or an extracted function and always send the full_path toinsert_asset()
where it's promptly dropped when the feature isn't turned on. That would be simpler.Changelog