Allow user to choose default ui camera #11436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
matiqo15
approved these changes
Jan 20, 2024
Co-authored-by: Mateusz Wachowiak <mateusz_wachowiak@outlook.com>
doonv
reviewed
Jan 20, 2024
alice-i-cecile
approved these changes
Jan 27, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
# Objective - Resolves bevyengine#11377 ## Solution - Add marker component `IsDefaultUiCamera` that will be choosen first as the default camera. If you want the IsDefaultUiCamera default camera to be in another window, thats now possible. - `IsDefaultUiCamera` is expected to be within a single Camera, if that assertion fails, one PrimaryWindow Camera will be choosen. --- ## Changelog ### Added - Added `IsDefaultUiCamera` marker component. --------- Co-authored-by: Mateusz Wachowiak <mateusz_wachowiak@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
IsDefaultUiCamerathat will be choosen first as the default camera.If you want the IsDefaultUiCamera default camera to be in another window, thats now possible.
IsDefaultUiCamerais expected to be within a single Camera, if that assertion fails, one PrimaryWindow Camera will be choosen.Changelog
Added
IsDefaultUiCameramarker component.