Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bevy_reflect: Reflect &'static str #11686

Merged
merged 2 commits into from
Feb 4, 2024
Merged

bevy_reflect: Reflect &'static str #11686

merged 2 commits into from
Feb 4, 2024

Conversation

MrGVSV
Copy link
Member

@MrGVSV MrGVSV commented Feb 3, 2024

Objective

&'static str doesn't implement Reflect. I don't think this was intentionally excluded.

Solution

Make &'static str implement Reflect.

Changelog

  • Implement Reflect and friends for &'static str
  • Add missing Reflect::debug implementation for Cow<'static, str>

@MrGVSV MrGVSV added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Feb 3, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 4, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 4, 2024
Merged via the queue into bevyengine:main with commit 71be08a Feb 4, 2024
27 checks passed
@atornity atornity mentioned this pull request Feb 4, 2024
Merged
tjamaan pushed a commit to tjamaan/bevy that referenced this pull request Feb 6, 2024
@MrGVSV @tjamaan
bevy_reflect: Reflect &'static str (bevyengine#11686)
99f2ac4 
# Objective

`&'static str` doesn't implement `Reflect`. I don't think this was
intentionally excluded.

## Solution

Make `&'static str` implement `Reflect`.

---

## Changelog

- Implement `Reflect` and friends for `&'static str`
- Add missing `Reflect::debug` implementation for `Cow<'static, str>`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Reflection
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrGVSV @james7132 @alice-i-cecile