Commits on Feb 5, 2024

1. Intern entity paths for faster comparisons. …

   This patch places all entity paths into a shared table so that comparing
   them is as cheap as a pointer comparison. We don't use the pre-existing
   `Interner` type because that leaks all strings added to it, and I was
   uncomfortable with leaking names, as Bevy apps might dynamically
   generate them. Instead, I reference count all the names and use a linked
   list to stitch together paths into a tree. The interner uses a weak hash
   set from the [`weak-table`] crate.
   
   This patch is especially helpful for the two-phase animation PR bevyengine#11707,
   because two-phase animation gets rid of the cache from name to
   animation-specific slot, thus increasing the load on the hash table that
   maps paths to bone indices.
   
   Note that the interned table is a global variable behind a `OnceLock`
   instead of a resource. This is because it must be accessed from the glTF
   `AssetLoader`, which unfortunately has no access to Bevy resources.
   
   [`weak-table`]: https://crates.io/crates/weak-table

   

   pcwalton committed Feb 5, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for bca3439
   • Browse repository at this point

   Copy the full SHA

   bca3439 View commit details

   Browse the repository at this point in the history