Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
#10644 introduced nice "statically typed" labels that replace the old strings. I would like to propose some changes to the names introduced:
SubGraph2d
->Core2d
andSubGraph3d
->Core3d
. The names of these graphs have been / should continue to be the "core 2d" graph not the "sub graph 2d" graph. The crate is calledbevy_core_pipeline
, the modules are stillcore_2d
andcore_3d
, etc.Labels2d
andLabels3d
, at the very least, should not be plural to follow naming conventions. A Label enum is not a "collection of labels", it is a specific Label. However I thinkLabel2d
andLabel3d
is significantly less clear thanNode2d
andNode3d
, so I propose those changes here. I've done the same forLabelsPbr
->NodePbr
andLabelsUi
->NodeUi
Additionally, #10644 accidentally made one of the Camera2dBundle constructors use the 3D graph instead of the 2D graph. I've fixed that here.
Changelog
SubGraph2d
->Core2d
,SubGraph3d
->Core3d
,Labels2d
->Node2d
,Labels3d
->Node3d
,LabelsUi
->NodeUi
,LabelsPbr
->NodePbr