Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

irradiance: use textureSampleLevel for WebGPU support #11893

Merged
merged 1 commit into from
Feb 16, 2024
Merged

irradiance: use textureSampleLevel for WebGPU support #11893

merged 1 commit into from
Feb 16, 2024

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Use textureSampleLevel instead of textureSample

@mockersf @DGriffin91
use textureSampleLevel
fb01a6e 
Co-Authored-By: Griffin <33357138+DGriffin91@users.noreply.github.com>
@mockersf mockersf added the A-Rendering Drawing game state to the screen label Feb 16, 2024
@mockersf mockersf added this to the 0.13 milestone Feb 16, 2024
@pcwalton
Copy link
Contributor

LGTM

pcwalton
pcwalton approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@pcwalton pcwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 16, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 16, 2024
Merged via the queue into bevyengine:main with commit 9a2ce8e Feb 16, 2024
27 checks passed
@alice-i-cecile alice-i-cecile mentioned this pull request Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@pcwalton pcwalton pcwalton approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.

WebGPU support broken: 'textureSample' must only be called from uniform control flow
3 participants
@mockersf @pcwalton @alice-i-cecile