Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update split_screen example with 4 cameras #12010

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Update split_screen example with 4 cameras #12010

merged 1 commit into from
Feb 20, 2024

Conversation

djeedai
Copy link
Contributor

@djeedai djeedai commented Feb 20, 2024

Objective

Improve split_screen example to use 4 cameras.

This serves as a visual regression test for #12006.

Solution

With the fix of #11968:

image

Without (current main):

image

@djeedai
Update split_screen example with 4 cameras
b60b0e9 
This serves as a visual regression test for bevyengine#12006.
@djeedai djeedai added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples A-Windowing Platform-agnostic interface layer to run your app in P-Regression Functionality that used to work but no longer does. Add a test for this! labels Feb 20, 2024
JMS55
JMS55 approved these changes Feb 20, 2024
View reviewed changes
examples/3d/split_screen.rs Show resolved Hide resolved
ghost
ghost approved these changes Feb 20, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides fixing the issue, it makes the example much easier to digest IMO. LGTM in general though the indexed positioning may be confusing to some?

@ghost ghost added this to the 0.13.1 milestone Feb 20, 2024
@ghost ghost modified the milestones: 0.13.1, 0.14 Feb 20, 2024
@IceSentry IceSentry added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 20, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 20, 2024
Merged via the queue into bevyengine:main with commit 5a74ff6 Feb 20, 2024
29 checks passed
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@djeedai @msvbg
Update split_screen example with 4 cameras (bevyengine#12010)
9f69475 
# Objective

Improve `split_screen` example to use 4 cameras.

This serves as a visual regression test for bevyengine#12006.

## Solution

With the fix of bevyengine#11968:


![image](https://github.com/bevyengine/bevy/assets/6532395/57e9e013-7d23-429f-98ac-c6542d6b4bea)

Without (current `main`):


![image](https://github.com/bevyengine/bevy/assets/6532395/0b2a88a4-97f8-408d-8a0e-ce917efc668d)
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@djeedai @msvbg
Update split_screen example with 4 cameras (bevyengine#12010)
7b0d713 
# Objective

Improve `split_screen` example to use 4 cameras.

This serves as a visual regression test for bevyengine#12006.

## Solution

With the fix of bevyengine#11968:


![image](https://github.com/bevyengine/bevy/assets/6532395/57e9e013-7d23-429f-98ac-c6542d6b4bea)

Without (current `main`):


![image](https://github.com/bevyengine/bevy/assets/6532395/0b2a88a4-97f8-408d-8a0e-ce917efc668d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMS55 JMS55 JMS55 approved these changes

@rparrett rparrett rparrett left review comments

@IceSentry IceSentry IceSentry approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen A-Windowing Platform-agnostic interface layer to run your app in C-Examples An addition or correction to our examples P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.
5 participants
@djeedai @rparrett @IceSentry @JMS55 @alice-i-cecile