Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect GizmoConfigStore #12104

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Reflect GizmoConfigStore #12104

merged 1 commit into from
Feb 25, 2024

Conversation

SludgePhD
Copy link
Contributor

Objective

  • Make GizmoConfigStore play well with reflection-based workflows like editors.

Solution

  • #[derive(Reflect)] and call .register_type().

@james7132 james7132 added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types A-Gizmos Visual editor and debug gizmos labels Feb 25, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 25, 2024
@alice-i-cecile alice-i-cecile added this to the 0.13.1 milestone Feb 25, 2024
Merged via the queue into bevyengine:main with commit c0a52d9 Feb 25, 2024
27 checks passed
@SludgePhD SludgePhD deleted the reflect-gizmostore branch February 25, 2024 02:40
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@SludgePhD @msvbg
Reflect GizmoConfigStore (bevyengine#12104)
e22ef20 
# Objective

- Make `GizmoConfigStore` play well with reflection-based workflows like
editors.

## Solution

- `#[derive(Reflect)]` and call `.register_type()`.
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@SludgePhD @msvbg
Reflect GizmoConfigStore (bevyengine#12104)
e5c4264 
# Objective

- Make `GizmoConfigStore` play well with reflection-based workflows like
editors.

## Solution

- `#[derive(Reflect)]` and call `.register_type()`.
mockersf pushed a commit that referenced this pull request Feb 27, 2024
@SludgePhD @mockersf
Reflect GizmoConfigStore (#12104)
faa1387 
# Objective

- Make `GizmoConfigStore` play well with reflection-based workflows like
editors.

## Solution

- `#[derive(Reflect)]` and call `.register_type()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablo-lua pablo-lua pablo-lua approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Gizmos Visual editor and debug gizmos A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
0.13.1
Development

Successfully merging this pull request may close these issues.
4 participants
@SludgePhD @james7132 @pablo-lua @alice-i-cecile