Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docstrings for some Commands to use the correct type #12111

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Update docstrings for some Commands to use the correct type #12111

merged 1 commit into from
Feb 25, 2024

Conversation

cBournhonesque
Copy link
Contributor

Objective

  • A tiny nit I noticed; I think the type of these function is EntityCommand, not Command

@cBournhonesque cBournhonesque added C-Docs An addition or correction to our documentation A-ECS Entities, components, systems, and events labels Feb 25, 2024
alice-i-cecile
alice-i-cecile approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merging as trivial.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 25, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 25, 2024
Merged via the queue into bevyengine:main with commit 5bcc100 Feb 25, 2024
28 checks passed
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@cBournhonesque @cbournhonesque-sc @msvbg
Update docstrings for some Commands to use the correct type (bevyengi…
9db09ab 
…ne#12111)

# Objective

- A tiny nit I noticed; I think the type of these function is
`EntityCommand`, not `Command`

Co-authored-by: Charles Bournhonesque <cbournhonesque@snapchat.com>
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@cBournhonesque @cbournhonesque-sc @msvbg
Update docstrings for some Commands to use the correct type (bevyengi…
b47ff13 
…ne#12111)

# Objective

- A tiny nit I noticed; I think the type of these function is
`EntityCommand`, not `Command`

Co-authored-by: Charles Bournhonesque <cbournhonesque@snapchat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cBournhonesque @alice-i-cecile @cbournhonesque-sc