Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register fxaa::Sensitivity and derive Debug #12167

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Register fxaa::Sensitivity and derive Debug #12167

merged 1 commit into from
Feb 28, 2024

Conversation

SludgePhD
Copy link
Contributor

Objective

  • More reflection

Solution

  • More. Reflection.

(not sure what bevy's policy on derive(Debug) is given that reflection already lets you accomplish something largely equivalent; maybe derive(Reflect) should generate a Debug impl that goes through Reflect::debug unless you opt out?)

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Feb 28, 2024
alice-i-cecile
alice-i-cecile approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally include both Reflect and Debug: Debug plays better with external tools and convenience printing methods.

@james7132 james7132 added this pull request to the merge queue Feb 28, 2024
Merged via the queue into bevyengine:main with commit ecdd284 Feb 28, 2024
28 checks passed
@SludgePhD SludgePhD deleted the fxaa-reflection-fix branch February 28, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SludgePhD @james7132 @alice-i-cecile