Remove initialize_resource<T> and friends #12307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
added
A-ECS
alice-i-cecile
approved these changes
Mar 5, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
hymm
approved these changes
Mar 5, 2024
hymm
added
the
S-Ready-For-Final-Review
spectria-limina
pushed a commit
to spectria-limina/bevy
that referenced
this pull request
Mar 9, 2024
# Objective `initialize_resource<T>` and it's non-send equivalent is only used in two locations each. Fix bevyengine#6285. ## Solution Remove them, replace their calls with their internals. Cut down on a bit of generic codegen. This does mean that `initialize_resource_internal` is now `pub(crate)`, but that's likely OK given that only one variant will remain once NonSend resources are removed from the World.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
initialize_resource<T>and it's non-send equivalent is only used in two locations each. Fix #6285.Solution
Remove them, replace their calls with their internals. Cut down on a bit of generic codegen.
This does mean that
initialize_resource_internalis nowpub(crate), but that's likely OK given that only one variant will remain once NonSend resources are removed from the World.