bevy_utils: Add BuildHasher parameter to bevy_utils::Entry type alias
#12308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
added
C-Usability
james7132
approved these changes
Mar 5, 2024
|
Merging as trivial. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alice-i-cecile
added
the
S-Ready-For-Final-Review
spectria-limina
pushed a commit
to spectria-limina/bevy
that referenced
this pull request
Mar 9, 2024
…lias (bevyengine#12308) # Objective `bevy_utils::Entry` is only useful when using `BuildHasherDefault<AHasher>`. It would be great if we didn't have to write out `bevy_utils::hashbrown::hash_map::Entry` whenever we want to use a different `BuildHasher`, such as when working with `bevy_utils::TypeIdMap`. ## Solution Give `bevy_utils::Entry` a new optional type parameter for defining a custom `BuildHasher`, such as `NoOpHash`. This parameter defaults to `BuildHasherDefault<AHasher>`— the `BuildHasher` used by `bevy_utils::HashMap`. --- ## Changelog - Added an optional third type parameter to `bevy_utils::Entry` to specify a custom `BuildHasher`
mtsr
pushed a commit
to mtsr/bevy
that referenced
this pull request
Mar 15, 2024
…lias (bevyengine#12308) # Objective `bevy_utils::Entry` is only useful when using `BuildHasherDefault<AHasher>`. It would be great if we didn't have to write out `bevy_utils::hashbrown::hash_map::Entry` whenever we want to use a different `BuildHasher`, such as when working with `bevy_utils::TypeIdMap`. ## Solution Give `bevy_utils::Entry` a new optional type parameter for defining a custom `BuildHasher`, such as `NoOpHash`. This parameter defaults to `BuildHasherDefault<AHasher>`— the `BuildHasher` used by `bevy_utils::HashMap`. --- ## Changelog - Added an optional third type parameter to `bevy_utils::Entry` to specify a custom `BuildHasher`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_utils::Entryis only useful when usingBuildHasherDefault<AHasher>. It would be great if we didn't have to write outbevy_utils::hashbrown::hash_map::Entrywhenever we want to use a differentBuildHasher, such as when working withbevy_utils::TypeIdMap.Solution
Give
bevy_utils::Entrya new optional type parameter for defining a customBuildHasher, such asNoOpHash. This parameter defaults toBuildHasherDefault<AHasher>— theBuildHasherused bybevy_utils::HashMap.Changelog
bevy_utils::Entryto specify a customBuildHasher