Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about rotations for Aabb3d #12315

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Jondolf
Copy link
Contributor

@Jondolf Jondolf commented Mar 5, 2024

Objective

Fixes #12310.

#11681 added transformations for bounding volumes, but I accidentally only added a note in the docs about repeated rotations for Aabb2d and not Aabb3d.

Solution

Copy the docs over to Aabb3d.

@Jondolf Jondolf added C-Docs An addition or correction to our documentation A-Math Fundamental domain-agnostic mathematical operations labels Mar 5, 2024
Copy link
Contributor

@NthTensor NthTensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@james7132 james7132 added this pull request to the merge queue Mar 5, 2024
Merged via the queue into bevyengine:main with commit 4bed1b2 Mar 5, 2024
28 checks passed
@Jondolf Jondolf deleted the fix-aabb3d-rotation-docs branch March 5, 2024 18:09
spectria-limina pushed a commit to spectria-limina/bevy that referenced this pull request Mar 9, 2024
# Objective

Fixes bevyengine#12310.

bevyengine#11681 added transformations for bounding volumes, but I accidentally
only added a note in the docs about repeated rotations for `Aabb2d` and
not `Aabb3d`.

## Solution

Copy the docs over to `Aabb3d`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add note about transforming 3D bounding volumes
3 participants