Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reflection for resources #1260

Closed
wants to merge 1 commit into from
Closed

Conversation

Davier
Copy link
Contributor

@Davier Davier commented Jan 18, 2021

I need a way to dynamically access resources, and I believe it's also an important feature for the future editor and scripting engines.

While this PR works in basic tests, I have a poor understanding of bevy_reflect so I'm not yet confident the implementation is correct. I'm opening the PR especially to get feedback on the API.

@alice-i-cecile alice-i-cecile added A-Core Common functionality for all bevy apps help wanted labels Feb 17, 2021
Base automatically changed from master to main February 19, 2021 20:44
@Davier
Copy link
Contributor Author

Davier commented Mar 19, 2021

This implementation is no longer relevant since resources are now special components.
It is (as far as I can tell) still not possible to reflect on them, since ReflectComponent's methods take an Entity.
I'm closing this PR, and will write an RFC on that topic soon.

@Davier Davier closed this Mar 19, 2021
@Davier Davier deleted the reflect_resource branch March 19, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core Common functionality for all bevy apps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants